[Deque Re-Analysis] Submission "critical" accessibility issues

[davide-negretti]

References

• Fixes [Deque Re-Analysis] Submission "critical" accessibility issues #1316

Description

The following accessibility issues have been fixed:

• 469979
• 470065
• 469700 - Solved in a different way (proposed solution was not compliant)
• 469984
• 469993 - Solved according to https://www.w3.org/TR/wai-aria-1.1/#combobox
• 470001
• 470010
• 470062 - Solved in a better way for screen readers

The following accessibility issue cannot be fixed:

• 470011 - Cannot be solved as it depends on an external plugin

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR doesn't introduce circular dependencies
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[tdonohue]

Thanks @davidenegretti-4science ! Apologies for not getting to review this until now. Looks good overall... I also verified each fix individually (✔️ means I tested and it looks fixed to me):

• ✔️ 469979
• ✔️ 470065
• ✔️469700
• ✔️469984
• ✔️469993
• ✔️470001 (MOSTLY FIXED. See inline comment below)
• ✔️470010
• ✔️470062

I'll go ahead and approve this, as I verified each of the fixes...however, I have one minor inline comment below that would be nice to fix in order to fully resolve 470001. Thanks!

[tdonohue]

Thanks for the small updates, @davidenegretti-4science ! Merging this now with one approval.