Switch to Commands for basic example #13
Conversation
themonarchoftime
changed the title
now it does |
| public static async Task Main(string[] args) | ||
| { | ||
| ConfigurationBuilder configurationBuilder = new(); | ||
| configurationBuilder.AddEnvironmentVariables(""); |
There was a problem hiding this comment.
this is, at a glance, rather questionable. we should also probably encourage a config file to at least be considered
There was a problem hiding this comment.
Config files... For an example bot? The purpose of an example bot is to demonstrate how to do XYZ while being easy to setup and run.
Also I think this might throw, if it hasn't been tested
| { | ||
| DiscordClient client = new(new DiscordConfiguration() | ||
| { | ||
| Token = configuration.GetValue<string>("discord:token") ?? |
There was a problem hiding this comment.
consider renaming "discord" in the eaxmples to "example-bot", to make clear what this identifier is
There was a problem hiding this comment.
It's grabbing the discord token from the discord property:
{
"discord":
{
"token": "invalid"
}
}| }); | ||
| IServiceProvider serviceProvider = serviceCollection.BuildServiceProvider(); | ||
|
|
||
| DiscordClient client = await serviceProvider.GetRequiredService<Task<DiscordClient>>(); |
There was a problem hiding this comment.
asked by lunar in last review
There was a problem hiding this comment.
#13 (comment)
i think this comment is meant which was to a different part of the code
There was a problem hiding this comment.
No, this is intended. Adding processors is an asynchronous operation. Encouraging .GetAwaiter().GetResult() goes against everything I've worked on within the lib, especially when it's done on ValueTasks.
There was a problem hiding this comment.
I would do the whole setup outside the AddSinglton and then add the client
Please revert. We'll delete when CNext is officially deprecated |
This reverts commit c3aa229.
|
reverted |
| { | ||
| ConfigurationBuilder configurationBuilder = new(); | ||
| // you can also use environment vars, just uncomment this | ||
| // configurationBuilder.AddEnvironmentVariables(""); |
There was a problem hiding this comment.
// right click on config.json, click properties, and in Copy to Output Directory select Copy if newer
i hate cnext.
basics done only for now, also updated dependencies for all projects for now