Generic ecotype read #472
Open
Generic ecotype read #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
January 9, 2025 11:34
- Ecotype ID is expected in first 6 characters. - All other columns are free-form with data assumed to be right-aligned with headers. - Variables are requested one at a time using the header (LABEL) - Values sent back are numeric. (cherry picked from commit cc5d0d2)
(cherry picked from commit a13687a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a generic read routine for ecotype files. It has been implemented for CROPGRO, but not yet other crops.
The new file ECO_read.for reads all ecotype parameters for the current eoctype and stores in memory for retrieval by crop routines with a separate call for each parameter requested. Ecotype files must be one line per ecotype with the data values right-justified under each header. Values are stored in memory as text, but sent back as real. Integer values are converted by the calling routine.
A new ecotype file is read each time the routine is called with input parameter LABEL = 'NEW'. This call must be done prior to any other calls to the routine.
Missing values are identified on a crop model-specific basis. For example, if the strawberry parameter XFPHT is not found, the problem is ignored unless this is a strawberry simulation. Parameters for cotton lint and fresh weight are also tested in this way. Other crop model-specific parameters can be easily added.
Some genotype files had to be changed:
Testing - I ran all CROPGRO experiments / treatments and compared with the previous model prior to these changes. There were differences but they reflect differences between debug and release model versions, with the same experiments / treatments affected. I'm inclined to ignore these, but we might need to investigate further, particularly with the worst problem soybean treatment (NCRM8701.SBX trt 24).