Michelle-part2 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
@michellewliang is the screen recording updated? |
|
@michellewliang recording looks good. Good work on Part 2. Looking forward to your part 3 PR |
|
I'll close your PR for now since we don't actually want to merge these changes into the real DLP app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Michelle-part2
Github Issue Number Here: <YOUR_GITHUB_ISSUE_NUMBER_HERE (include the hashtag)>
What user problem are we solving?
What solution does this PR provide?
Testing Methodology
How did you test your changes and verify that existing
functionality is not broken
Any other [considerations[]
Screen recording: https://drive.google.com/file/d/1mPYYrHbiHZWkrujtOjM_omtd6OEHqojV/view?usp=drive_link