Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mugdhesh-part3 #15

Closed
wants to merge 3 commits into from
Closed

mugdhesh-part3 #15

wants to merge 3 commits into from

Conversation

MugPand
Copy link

@MugPand MugPand commented Dec 10, 2023

Title of Pull Request HERE

Github Issue Number Here: <YOUR_GITHUB_ISSUE_NUMBER_HERE (include the hashtag)>
What user problem are we solving?

What solution does this PR provide?

Testing Methodology
How did you test your changes and verify that existing
functionality is not broken

Any other considerations

part3.mov

@MugPand MugPand requested a review from a team as a code owner December 10, 2023 19:58
Copy link

sweep-ai bot commented Dec 10, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

sonarcloud bot commented Dec 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@karkir0003
Copy link
Member

@MugPand looks good to me. Great work on this PR. Code is very clean. We will not merge this PR in due to this task being in context of the beginner project. Looking forward to part 4 PR from you!

P.S: You don't need the Miniforge.sh and the AWSCLIV2 package files within the project repo

@karkir0003 karkir0003 closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants