Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

andrew-part2 #11

Closed
wants to merge 2 commits into from
Closed

andrew-part2 #11

wants to merge 2 commits into from

Conversation

andrewpeng02
Copy link
Collaborator

@andrewpeng02 andrewpeng02 requested a review from a team as a code owner November 29, 2023 17:01
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.6% 5.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 29, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

karkir0003
karkir0003 reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. great work @andrewpeng02

ill mark this pr as closed since we wont actually merge these changes into the real dlp app

@karkir0003 karkir0003 closed this Nov 29, 2023
@karkir0003
Copy link
Member

looking forward to part 3 pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karkir0003 karkir0003 karkir0003 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewpeng02 @karkir0003