hartej (part 2) #10
hartej (part 2) #10
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
backendCore/dl/dl_trainer.py
Outdated
| @@ -259,6 +259,10 @@ def train_deep_model( | |||
| return train_deep_regression_model( | |||
| model, train_loader, test_loader, optimizer, criterion, epochs | |||
| ) | |||
| elif problem_type.upper() == ProblemType.get_problem_obj(ProblemType.NONE): | |||
There was a problem hiding this comment.
🚫 [pyright] reported by reviewdog 🐶
Cannot access member "NONE" for type "type[ProblemType]"
Member "NONE" is unknown (reportGeneralTypeIssues)
Apply Sweep Rules to your PR?
|
|
Hey @hartejsingh12, there is an issue in the build check where you have two different, yet similar if conditions that lead to the same outcome. We should clean that up in order to get into the clean code habit |
|
Kudos, SonarCloud Quality Gate passed!
|
Fixed! |
|
@hartejsingh12 Good work on this. I'll be marking your PR as closed since we don't want to actually merge these changes into the real DLP app. Looking forward to your Part 3 PR |
hartej (part 2)
Github Issue Number Here: <YOUR_GITHUB_ISSUE_NUMBER_HERE (include the hashtag)>
What user problem are we solving?
What solution does this PR provide?
Testing Methodology
How did you test your changes and verify that existing
functionality is not broken
Any other considerations
Screen recording:
https://www.youtube.com/watch?v=vcNmMt4-spQ