React flow integration #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayground into react-flow-integration-trainspace
|
@farisdurrani screen recording? |
karkir0003
reviewed
Sep 13, 2023
karkir0003
reviewed
Sep 13, 2023
karkir0003
reviewed
Sep 13, 2023
karkir0003
reviewed
Sep 13, 2023
There was a problem hiding this comment.
looks good to me. left a few comments/questions.
@dwu359 , can you take a look
…e' into react-flow-integration-trainspace
dwu359
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React flow integration
What user problem are we solving?
The current ReactDnD tool is complex in nature and does not allow for parallel layers of architecture.
What solution does this PR provide?
Addressing #890 , this PR integrates React Flow as an alternative drag-n-drop tool replacing ReactDnd. This allows people to drag and drop new layers, as well as add parameter info and in the future, this will allow parallel layers of architecture.
Deep.Learning.Playground.-.12.September.2023.mp4
Testing Methodology
How did you test your changes and verify that existing
functionality is not broken
Basic testing on Iris and MNIST training.
Any other considerations