914 [Feature] - "Add remaining CRUD endpoints to SST" #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alantao912
requested review from
karkir0003,
farisdurrani and
dwu359
as code owners
karkir0003
reviewed
Sep 3, 2023
serverless/packages/functions/src/datasets/user/delete_userdata.ts
Outdated
Show resolved
Hide resolved
|
Sept 23rd. Latest |
alantao912
changed the title
karkir0003
reviewed
Sep 22, 2023
serverless/packages/functions/src/trainspace/get_all_trainspace.ts
Outdated
Show resolved
Hide resolved
karkir0003
reviewed
Sep 22, 2023
|
karkir0003
reviewed
Sep 22, 2023
There was a problem hiding this comment.
Looks good to me. Thanks for the awesome work on this. @dwu359 will review your pr and leave his comments.
https://github.com/DSGT-DLP/Deep-Learning-Playground into 914-feature-add-the-rest-of-the-crud-endpoints-to-sst
karkir0003
reviewed
Oct 23, 2023
serverless/packages/functions/src/datasets/user/delete_userdata.ts
Outdated
Show resolved
Hide resolved
dwu359
requested changes
Oct 27, 2023
serverless/packages/functions/src/trainspace/delete_trainspace.ts
Outdated
Show resolved
Hide resolved
serverless/packages/functions/src/trainspace/delete_trainspace.ts
Outdated
Show resolved
Hide resolved
serverless/packages/functions/src/trainspace/delete_trainspace.ts
Outdated
Show resolved
Hide resolved
serverless/packages/functions/src/datasets/user/delete_user_uploaded_data.ts
Outdated
Show resolved
Hide resolved
dwu359
requested changes
Oct 29, 2023
There was a problem hiding this comment.
A few minor changes before I do a full review. Also rename these files to be consistent with the rest of the sst code:
- create_image_trainspace -> create_image
- create_tabular_trainspace -> create_tabular
- delete_trainspace -> delete
- get_all_trainspace -> get_all
serverless/packages/functions/src/trainspace/create_image_trainspace.ts
Outdated
Show resolved
Hide resolved
serverless/packages/functions/src/trainspace/create_tabular_trainspace.ts
Outdated
Show resolved
Hide resolved
https://github.com/DSGT-DLP/Deep-Learning-Playground into 914-feature-add-the-rest-of-the-crud-endpoints-to-sst
farisdurrani
approved these changes
Nov 10, 2023
|
You're quite behind the nextjs branch. Just fix the conflicts and you should be good to go 👍 @alantao912 |
|
Kudos, SonarCloud Quality Gate passed!
|
dwu359
approved these changes
Nov 11, 2023
alantao912
deleted the
914-feature-add-the-rest-of-the-crud-endpoints-to-sst
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added remaining trainspace CRUD endpoints to SST
What user problem are we solving?
Trainspace creation, deletion, management, and deletion of user uploaded datset.
What solution does this PR provide?
Allowing users to create new, retrieve specific, retrieve all, delete specific trainspace, and delete specific user uploaded dataset using AWS Lambda.
Testing Methodology
Tested API endpoints on locally with postman using a developer account.
Created new trainspace, retrieved it, created several new trainspaces, retrieved all, deleted trainspace, attempted (and successfully failed) to retrieve previously deleted trainspace, and deleted user uploaded data successfully.
Any other considerations