Feature 1137 Create Terraform scripts for ECS backend #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpeng02
force-pushed
the
feature-1137-terraform-ecs
branch
from
4e548b3
to
1d82d50
Compare
andrewpeng02
had a problem deploying
to
production
GitHub Actions
Failure
andrewpeng02
force-pushed
the
feature-1137-terraform-ecs
branch
3 times, most recently
from
7a91557
to
fb6e528
Compare
andrewpeng02
temporarily deployed
to
production
GitHub Actions
Inactive
andrewpeng02
changed the title
andrewpeng02
force-pushed
the
feature-1137-terraform-ecs
branch
from
fb6e528
to
a211b97
Compare
andrewpeng02
had a problem deploying
to
production
GitHub Actions
Failure
andrewpeng02
had a problem deploying
to
production
GitHub Actions
Failure
andrewpeng02
force-pushed
the
feature-1137-terraform-ecs
branch
from
af15f44
to
93aa18b
Compare
|
karkir0003
reviewed
Mar 2, 2024
karkir0003
reviewed
Mar 2, 2024
karkir0003
reviewed
Mar 2, 2024
karkir0003
reviewed
Mar 2, 2024
karkir0003
reviewed
Mar 2, 2024
|
@andrewpeng02 AWESOME work on this! Really love the thoroughness here. Love the detailed testing provided. I added a few minor questions/comments. Could you address those and tag me for re-review? Also, what would be the next steps after this PR? |
|
Next steps are moving the training into the training containers #1136 @karkir0003 |
karkir0003
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up AWS infrastructure for the backend
Github Issue Number Here: #1137
What user problem are we solving?
We want to use Terraform for the aws infrastructure so that everything is defined in code. This Terraform code sets up the architecture specified in the diagram below. ALB routes requests to ECS fargate, which houses the Django backend containers. It also sets up ECS with EC2 launch type (g4dn.xlarge) that'll eventually be used for the training workers, but right now they don't do anything yet..
Testing Methodology
cd dlp-terraform/ecsterraform applyHTTP GET http://alb-[id].us-east-1.elb.amazonaws.com/api/datasets/default/IRIS/columns gets the proper columns when passed a Bearer token
terraform destroy