Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused backendCore/ and aws_write/ directories #1080

Merged
merged 2 commits into from
Jan 2, 2024
Merged

remove unused backendCore/ and aws_write/ directories #1080

merged 2 commits into from
Jan 2, 2024

Conversation

ssh51117
Copy link
Collaborator

Removed unused backendCore/ and aws_write/ directories

Github Issue Number Here: #1014
What user problem are we solving?
Removing unused directories from old versions
What solution does this PR provide?
Deleted directories
Testing Methodology

How did you test your changes and verify that existing functionality is not broken
existing build check, did code search to see if directories are used, and spun up app and clicked around to see if anything broke
Any other considerations
N/A

@ssh51117 ssh51117 requested a review from a team as a code owner December 30, 2023 04:02
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Dec 30, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 30, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

dwu359
dwu359 approved these changes Jan 1, 2024
View reviewed changes
Copy link
Contributor

@dwu359 dwu359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssh51117 ssh51117 added this pull request to the merge queue Jan 2, 2024
Merged via the queue into nextjs with commit d314258 Jan 2, 2024
4 checks passed
@ssh51117 ssh51117 deleted the feature-1014 branch January 2, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farisdurrani farisdurrani farisdurrani approved these changes

@dwu359 dwu359 dwu359 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssh51117 @farisdurrani @dwu359