Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust architecture.md to display /training directory #1079

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Conversation

LuHG18
Copy link
Collaborator

@LuHG18 LuHG18 commented Dec 29, 2023

Fixed Architecture.md file to display /training directory instead of /backend

Github Issue Number Here: #991

Testing Methodology
Made the fix and I tested my changes by reviewing the Architecture.md on my branch to make sure that it was properly updated. I went through each folder and file of the /training section to make sure it was displaying the correct content in accordance to the directory structure.

@LuHG18 LuHG18 requested a review from a team as a code owner December 29, 2023 20:35
Copy link
Contributor

sweep-ai bot commented Dec 29, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@karkir0003
Copy link
Member

Minor comment @LuHG18, can you please add a brief section in your PR description regarding how you tested the changes.

Once you do that, please re-request review

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Lucas on this change!

@LuHG18 LuHG18 added this pull request to the merge queue Dec 29, 2023
Merged via the queue into nextjs with commit 3231870 Dec 29, 2023
4 checks passed
@LuHG18 LuHG18 deleted the bug-991 branch December 29, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants