Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATED FEATURE-993] Migrate Image Training Endpoint to Django #1053

Merged
merged 24 commits into from
Nov 20, 2023

Conversation

codingwithsurya
Copy link
Contributor

@codingwithsurya codingwithsurya commented Nov 19, 2023

Github Issue Number Here: Feature #993

What user problem are we solving?

With the ongoing migration from Flask Blueprint to Django for better scalability and maintainability, we need to ensure that the training endpoints for image datasets continue to function as expected. Users need a reliable endpoint to submit image training requests and this migration aims to improve the overall infrastructure.

What solution does this PR provide?

This PR introduces the /image route within the Django framework, replacing the old Flask Blueprint route. The new route handles image training requests, particularly focusing on classification tasks as regression is not supported. The structure of this endpoint is mirrored from the specified reference, with adjustments made to fit the Django framework. The old image train code served as inspiration for ensuring that the necessary features and behaviors are retained.

Testing Methodology

Testing yet to be done but to verify the functionality and integrity of the new /image route, but when testing begins, we can submit training requests using torch built-in datasets (MNIST, FashionMNIST) to ensure that models train as expected and the endpoint returns accurate results.

Also use postman for testing .

Any other considerations

THIS IS UPDATED PR.

@codingwithsurya codingwithsurya requested a review from a team as a code owner November 19, 2023 21:46
Copy link
Contributor

sweep-ai bot commented Nov 19, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work on this so far. had a few nits + questions. please address and then re-request review

training/training/core/dataset.py Show resolved Hide resolved
training/training/core/dataset.py Show resolved Hide resolved
training/training/routes/image/image.py Show resolved Hide resolved
training/training/routes/image/image.py Show resolved Hide resolved
training/training/routes/image/image.py Show resolved Hide resolved
training/training/routes/image/schemas.py Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codingwithsurya codingwithsurya added this pull request to the merge queue Nov 20, 2023
Merged via the queue into nextjs with commit c9f07ec Nov 20, 2023
5 checks passed
@codingwithsurya codingwithsurya deleted the feature-993-updated branch November 20, 2023 04:01
@codingwithsurya codingwithsurya linked an issue Nov 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Migrate Image Training Endpoint
2 participants