Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Documents Enhancements and fail on failed Polarion Requests #95

Merged
merged 7 commits into from
Aug 18, 2024

Conversation

micha91
Copy link
Collaborator

@micha91 micha91 commented Aug 16, 2024

  • The render-documents command was simplified and much of the code moved to the DocumentRenderer
  • Additional tests now also cover the render-documents command
  • If a document fails to get rendered, the job will continue to render the other documents and an Error message will be logged
  • If a Polarion request fails, it will get logged and an exception will be raised to stop the job

@micha91 micha91 requested a review from ewuerger August 16, 2024 11:05
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny things. LGTM.

capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/converters/document_renderer.py Outdated Show resolved Hide resolved
capella2polarion/converters/document_renderer.py Outdated Show resolved Hide resolved
@micha91 micha91 requested a review from ewuerger August 16, 2024 13:28
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micha91 micha91 merged commit 7406073 into main Aug 18, 2024
8 checks passed
@ewuerger ewuerger deleted the fail-on-failed-requests branch September 6, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants