Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Detect invalid link configurations #94

Merged
merged 3 commits into from
Aug 17, 2024
Merged

feat: Detect invalid link configurations #94

merged 3 commits into from
Aug 17, 2024

Conversation

micha91
Copy link
Collaborator

@micha91 micha91 commented Aug 14, 2024

  • log invalid links
  • don't try to create them anymore

ewuerger
ewuerger requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor style thing.
LGTM afterwards.

capella2polarion/converters/converter_config.py Outdated Show resolved Hide resolved
@micha91 micha91 requested a review from ewuerger August 16, 2024 11:02
ewuerger
ewuerger approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@micha91 micha91 merged commit 65a312c into main Aug 17, 2024
8 checks passed
@ewuerger ewuerger deleted the check-link-config branch September 6, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewuerger ewuerger ewuerger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micha91 @ewuerger