fix: Fix duplication of logging messages #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewuerger
force-pushed
the
fix-logging
branch
2 times, most recently
from
ff4d3e3
to
ce32fad
Compare
micha91
requested changes
Feb 27, 2024
Gather error findings in a dict and log them afterwards.
micha91
requested changes
Feb 28, 2024
ewuerger
force-pushed
the
fix-logging
branch
from
9901df7
to
25ce3b4
Compare
ewuerger
force-pushed
the
fix-logging
branch
from
25ce3b4
to
21e56b3
Compare
micha91
approved these changes
Feb 29, 2024
ewuerger
force-pushed
the
fix-logging
branch
from
2246f94
to
73747b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17. Wouldn't go as far as #30 describes for now.
The commits will be squashed.