feat: Redirect root to prefix #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamilraichouni
force-pushed
the
prefix-redirect
branch
from
10db603 to
a4ee213
Compare
jamilraichouni
force-pushed
the
prefix-redirect
branch
from
a4ee213 to
b731598
Compare
jamilraichouni
force-pushed
the
prefix-redirect
branch
from
b731598 to
b1d7c8a
Compare
When `CME_ROUTE_PREFIX` is set, redirect root to the prefix.
jamilraichouni
force-pushed
the
prefix-redirect
branch
from
b1d7c8a to
42623b5
Compare
Comment on lines
+38
to
+43
| if any( | ||
| ( | ||
| c.ROUTE_PREFIX and not c.ROUTE_PREFIX.startswith("/"), | ||
| "/" in c.ROUTE_PREFIX and not c.ROUTE_PREFIX.replace("/", ""), | ||
| ) | ||
| ): |
There was a problem hiding this comment.
We don't need the any function call here, a simple or in between is enough. Plus, or evaluates the second condition lazily.
If we additionally .rstrip("/") the ROUTE_PREFIX in constants.py:47, a string consisting only of forward slashes will become an empty string, which is valid input. Given that, we can drastically simplify this condition to:
if c.ROUTE_PREFIX and not c.ROUTE_PREFIX.startswith("/"):
Comment on lines
+38
to
+45
| if any( | ||
| ( | ||
| c.ROUTE_PREFIX and not c.ROUTE_PREFIX.startswith("/"), | ||
| "/" in c.ROUTE_PREFIX and not c.ROUTE_PREFIX.replace("/", ""), | ||
| ) | ||
| ): | ||
| logger.error("Route prefix is invalid.") | ||
| sys.exit(1) |
There was a problem hiding this comment.
This hangs in live mode for some reason, haven't yet investigated though.
| "/" in c.ROUTE_PREFIX and not c.ROUTE_PREFIX.replace("/", ""), | ||
| ) | ||
| ): | ||
| logger.error("Route prefix is invalid.") |
There was a problem hiding this comment.
Suggested change
| logger.error("Route prefix is invalid.") | |
| logger.error("Invalid route prefix: %r", c.ROUTE_PREFIX) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
CME_ROUTE_PREFIXis set, redirect root to the prefix.