Jupyter image #108
Merged
Jupyter image #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
I'm missing documentation here. It should be mentioned in the |
amolenaar
force-pushed
the
jupyter
branch
4 times, most recently
from
0c4101f to
3e02617
Compare
dominik003
reviewed
Feb 21, 2023
dominik003
reviewed
Feb 21, 2023
amolenaar
force-pushed
the
jupyter
branch
2 times, most recently
from
e365a7d to
3a67bb2
Compare
There was a problem hiding this comment.
Nice improvement, @amolenaar. Thank you :)
After the four steps are done, I'll merge the PR:
- Approval from @dominik003
- The one additional comment that I just added is resolved
- The Gitlab CI template is tested in our staging image builder environment
- The Github actions are green. Right now, the pre-commit action fails.
dominik003
approved these changes
Feb 22, 2023
MoritzWeber0
force-pushed
the
jupyter
branch
from
2410c1e to
c382438
Compare
Now uid's can be set in one place.
This instantly makes the jupyter image a *lot* more useful :)
Co-authored-by: dominik003 <[email protected]>
MoritzWeber0
approved these changes
Feb 27, 2023
MoritzWeber0
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Jupyter image from this repo, instead of Capella-collab-manager.
See also: DSD-DBS/capella-collab-manager#574