Merge pull request #36 from JosephGasiorekUSDS/jgasiorek-ffs-975

FFS-975: Enable Unused import eslint plugin

.eslintrc.json

@@ -1,3 +1,17 @@
 {
-  "extends": ["plugin:i18next/recommended", "next/core-web-vitals"]
+  "extends": ["plugin:i18next/recommended", "next/core-web-vitals"],
+  "plugins": ["unused-imports"],
+  "rules": {
+    "no-unused-vars": "off",
+    "unused-imports/no-unused-imports": "error",
+    "unused-imports/no-unused-vars": [
+        "warn",
+        {
+            "vars": "all",
+            "varsIgnorePattern": "^_",
+            "args": "after-used",
+            "argsIgnorePattern": "^_"
+        }
+    ]
+  }
 }

app/StoreProvider.tsx

@@ -1,6 +1,6 @@
 'use client'
 import { useRef } from "react"
-import { Provider, useDispatch } from "react-redux"
+import { Provider } from "react-redux"
 import { makeStore, AppStore } from '../lib/store'
 
 export default function StoreProvider({

app/[locale]/ledger/expense/add/page.test.tsx

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
 import { Provider } from 'react-redux'
 import Page from './page'

app/[locale]/ledger/expense/add/page.tsx

@@ -2,14 +2,12 @@
 import "@trussworks/react-uswds/lib/uswds.css"
 import "@trussworks/react-uswds/lib/index.css"
 import { useTranslation } from 'react-i18next'
-import { Header, Title, Button, Form, FormGroup, Grid, GridContainer, Alert, Checkbox, DatePicker, ErrorMessage, ComboBox, Label, ValidationChecklist, ValidationItem, RequiredMarker } from '@trussworks/react-uswds' 
+import { Header, Title, Button, Form, FormGroup, Grid, GridContainer, Alert, Checkbox, DatePicker, ComboBox, Label, ValidationChecklist, ValidationItem, RequiredMarker } from '@trussworks/react-uswds' 
 import { useAppDispatch } from "@/lib/hooks"
-import { ExpenseItem, addExpense, selectExpenseItems } from "@/lib/features/ledger/expenses/expensesSlice"
+import { ExpenseItem, addExpense } from "@/lib/features/ledger/expenses/expensesSlice"
 import { useRouter } from "next/navigation"
-import { FieldErrors, SubmitHandler, useForm, Controller } from "react-hook-form"
+import { SubmitHandler, useForm, Controller } from "react-hook-form"
 import TextFieldWithValidation from "@/app/components/TextFieldWithValidation"
-import { useRef, useImperativeHandle } from "react"
-import exp from "constants"
 import RequiredFieldDescription from "@/app/components/RequiredFieldDescription"
 
 export default function Page() {

app/[locale]/ledger/expense/list/page.test.tsx

@@ -1,5 +1,5 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
-import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
+import { cleanup, render, screen } from '@testing-library/react'
 import { Provider } from 'react-redux'
 import Page from './page'
 import { makeStore } from '@/lib/store'

app/[locale]/ledger/expense/list/page.tsx

@@ -2,7 +2,7 @@
 
 import "@trussworks/react-uswds/lib/uswds.css"
 import "@trussworks/react-uswds/lib/index.css"
-import { Header, Title, Button, ButtonGroup, CardGroup, ModalToggleButton, Modal, ModalHeading, ModalFooter, Card, CardBody, CardHeader, Grid, GridContainer, Label, TextInput, ModalRef } from '@trussworks/react-uswds' 
+import { Header, Title, Button, ButtonGroup, Grid, GridContainer } from '@trussworks/react-uswds' 
 import { useTranslation } from 'react-i18next'
 import { useRouter } from "next/navigation"
 import ExpenseList from "@/app/components/ExpenseList"

app/[locale]/ledger/expense/page.test.tsx

@@ -1,5 +1,5 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
-import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
+import { cleanup, render, screen } from '@testing-library/react'
 import { Provider } from 'react-redux'
 import Page from './page'
 import { makeStore } from '@/lib/store'

app/[locale]/ledger/expense/snap/page.test.tsx

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
 import { Provider } from 'react-redux'
 import Page from './page'

app/[locale]/ledger/expense/snap/page.tsx

@@ -2,9 +2,8 @@
 
 import "@trussworks/react-uswds/lib/uswds.css"
 import "@trussworks/react-uswds/lib/index.css"
-import { Header, Title, Button, HeadingLevel, Grid, GridContainer, Accordion, Radio, Form } from '@trussworks/react-uswds' 
+import { Header, Title, Button, Grid, GridContainer, Radio, Form } from '@trussworks/react-uswds' 
 import { useRouter } from "next/navigation"
-import Link from 'next/link'
 import { useTranslation } from "react-i18next"
 import { Controller, SubmitHandler, useForm } from "react-hook-form"
 
@@ -19,8 +18,6 @@ export default function Page() {
     }
 
     const {
-        register,
-        formState: { errors },
         handleSubmit,
         control
     } = useForm<FormData>()

app/[locale]/ledger/expense/snap/recommend/page.test.tsx

@@ -1,6 +1,5 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
-import { Provider } from 'react-redux'
 import Page from './page'
 import { makeStore } from '@/lib/store'
 import { vi } from 'vitest'

app/[locale]/ledger/expense/snap/recommend/page.tsx

@@ -48,7 +48,7 @@ export default function Page() {
             // User should not have been pushed to this screen
             return router.push('/ledger/review')
         }
-    }, [])
+    }, [benefits.snap, reccommendStandardDeduction, router])
 
     return (
         <div>

app/[locale]/ledger/income/add/page.test.tsx

@@ -1,14 +1,11 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
 import Page from './page'
-import { makeStore } from '@/lib/store'
 import { vi } from 'vitest'
-import { EnhancedStore } from '@reduxjs/toolkit'
 import mockRouter from 'next-router-mock'
 import TestWrapper from '@/app/TestWrapper'
 
 describe('Add Income To Ledger Page', async () => {
-    let store: EnhancedStore
     beforeEach(() => {
         vi.mock('next/navigation', () => require('next-router-mock'))
         mockRouter.push('/ledger/income/add')

app/[locale]/ledger/income/add/page.tsx

@@ -6,7 +6,7 @@ import { useTranslation } from 'react-i18next'
 import { useAppDispatch } from "@/lib/hooks"
 import { addIncome, IncomeItem } from "@/lib/features/ledger/income/incomeSlice"
 import { useRouter } from "next/navigation"
-import { FieldErrors, SubmitHandler, useForm, Controller } from "react-hook-form"
+import { FieldErrors, SubmitHandler, useForm } from "react-hook-form"
 import TextFieldWithValidation from "@/app/components/TextFieldWithValidation"
 import TextAreaWithValidation from "@/app/components/TextAreaWithValidation"
 import RequiredFieldDescription from "@/app/components/RequiredFieldDescription"

app/[locale]/ledger/income/list/page.test.tsx

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
 import { Provider } from 'react-redux'
 import Page from './page'
@@ -15,7 +15,6 @@ describe('List Income in Ledger Page', async () => {
         vi.mock('next/navigation', () => require('next-router-mock'))
         mockRouter.push('/ledger/income/add')
         store = makeStore()
-        // render (<Provider store={store}><Page /></Provider>)
     })
     afterEach(cleanup)
 

app/[locale]/ledger/review/LedgerReviewHeader.test.tsx

@@ -1,5 +1,5 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
-import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
+import { cleanup, render, screen } from '@testing-library/react'
 import LedgerReviewHeader from './LedgerReviewHeader'
 import { BenefitsState } from '@/lib/features/benefits/benefitsSlice'
 import TestWrapper from '@/app/TestWrapper'

app/[locale]/ledger/review/SnapExpenses.test.tsx

@@ -1,5 +1,5 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
-import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
+import { cleanup, render, screen, waitFor } from '@testing-library/react'
 import { Provider } from 'react-redux'
 import { makeStore } from '@/lib/store'
 import { EnhancedStore } from '@reduxjs/toolkit'

app/[locale]/ledger/review/page.test.tsx

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
 import { Provider } from 'react-redux'
 import Page from './page'

app/[locale]/page.test.tsx

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
 import { Provider } from 'react-redux'
 import Page from './page'

app/[locale]/statement/confirmation/page.tsx

@@ -3,17 +3,14 @@ import "@trussworks/react-uswds/lib/uswds.css"
 import "@trussworks/react-uswds/lib/index.css"
 import { Header, Title, Button,  Grid, GridContainer } from '@trussworks/react-uswds' 
 import { useTranslation } from 'react-i18next'
-import { useAppDispatch, useAppSelector } from "@/lib/hooks"
-import { useRouter } from "next/navigation"
+import { useAppSelector } from "@/lib/hooks"
 import { selectSignedStatement } from "@/lib/features/statement/statementSlice"
 import Link from "next/link"
 import Image from "next/image"
 import ledgerImage from './ledger.png'
 
 export default function Page() {
     const { t } = useTranslation()
-    const dispatch = useAppDispatch()
-    const router = useRouter()
     const signedStatement = useAppSelector((state) => selectSignedStatement(state))
 
     return (

app/[locale]/statement/set/page.test.tsx

@@ -1,12 +1,11 @@
-import { afterEach, beforeEach, describe, expect, it, test } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
 import { Provider } from 'react-redux'
 import Page from './page'
 import { makeStore } from '@/lib/store'
 import { vi } from 'vitest'
 import { EnhancedStore } from '@reduxjs/toolkit'
 import mockRouter from 'next-router-mock'
-import { selectSignedStatement } from '@/lib/features/statement/statementSlice'
 
 describe('Set Signed Statment', async () => {
     let store: EnhancedStore

app/components/TextFieldWithValidation.tsx

@@ -1,4 +1,4 @@
-import { ErrorMessage, Label, RequiredMarker, TextInput } from "@trussworks/react-uswds"
+import { ErrorMessage, Label, TextInput } from "@trussworks/react-uswds"
 import React, { FocusEventHandler } from "react"
 
 type Args = {

lib/actions.ts

@@ -1,3 +1,3 @@
-import { Action, createAction } from "@reduxjs/toolkit";
+import { createAction } from "@reduxjs/toolkit";
 
 export const setInitialStateAction = createAction<{}>('SET_INITIAL_STATE')

lib/hooks.ts

@@ -1,4 +1,4 @@
-import { useDispatch, useSelector, useStore } from "react-redux"
+import { useDispatch, useSelector } from "react-redux"
 import type { AppDispatch, RootState } from './store'
 
 export const useAppDispatch = useDispatch.withTypes<AppDispatch>()

lib/store.ts

@@ -1,4 +1,4 @@
-import { Action, ConfigureStoreOptions, Store, combineReducers, configureStore } from "@reduxjs/toolkit";
+import { Action, combineReducers, configureStore } from "@reduxjs/toolkit";
 import incomeReducer, { selectIncomeTotal } from './features/ledger/income/incomeSlice'
 import expenseReducer, { selectExpenseTotal } from './features/ledger/expenses/expensesSlice'
 import statementReducer from './features/statement/statementSlice'

package.json

@@ -41,6 +41,7 @@
     "eslint": "^8",
     "eslint-config-next": "14.2.3",
     "eslint-plugin-i18next": "^6.0.3",
+    "eslint-plugin-unused-imports": "^3.2.0",
     "jsdom": "^24.1.0",
     "pa11y-ci": "^3.1.0",
     "typescript": "^5",