Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display results #5

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Display results #5

merged 1 commit into from
Feb 20, 2024

Conversation

allthesignals
Copy link
Collaborator

Ticket

LINK TO TICKET

Changes

  1. Shows results of blurry detection on the confirmation page
  2. Includes type safety!

Context for reviewers

This isn't meant to look great. More just acts as a placeholder until things can be used.

Testing

image

@@ -31,7 +38,7 @@ export default async function handler(
const form = formidable({});
const [, files] = await form.parse(req);

const results = await Promise.allSettled(
const results: BlurryDetectorResults = await Promise.allSettled(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what the requirements are around persisting files? Would we need these at some other point in the future for the user to reference? If so then Vercel Blob storage or another 3rd party storage solution might be a good fit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeorgeCodes19 not sure what those reqs will be... For now we're just writing to local filesystem as a placeholder — no current need to retrieve the files later. I think it drops them in a tmp folder that gets wiped regularly.

If there's a need for it beyond proof of concept, definitely would like to look into something like Vercel's blob storage. I deployed on Netlify because that's what I'm familiar with, but would love to try out Vercel's server offering.

@allthesignals allthesignals merged commit a2dd696 into main Feb 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants