Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OWASP test #94

Closed
wants to merge 20 commits into from
Closed

Fix OWASP test #94

wants to merge 20 commits into from

Conversation

JosephGasiorekUSDS
Copy link
Contributor

@JosephGasiorekUSDS JosephGasiorekUSDS commented Jul 7, 2024

Ticket

Resolves FFS-1083

Changes

  • Bring OWASP tests back to working.

Context for reviewers

The OWASP test have not been running for some time.

Testing

Provide evidence that the code works as expected. Explain what was done for testing and the results of the test plan. Include screenshots, GIF demos, shell commands or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

@joeyg
Copy link
Contributor

joeyg commented Jul 25, 2024

@tdooner Are we able to put Sandbox credentials for pinwheel up on github? This fails because it try's to make requests to pinwheel

@tdooner
Copy link
Contributor

tdooner commented Jul 25, 2024

@joeyg We could, I guess, as a secret environment variable. Is OWASP going through every page in the app or something? I'm just trying to think about what the right thing to do here is architecturally - do we want to somehow stub out Pinwheel in test environments so we're not actually making 3rd party calls. Certainly the Pinwheel webhooks will not arrive properly without some legwork. Can we just have it exclude the "Start Flow Manually" link on the homepage if it's just crawling for links?

@joeyg
Copy link
Contributor

joeyg commented Jul 25, 2024

@tdooner you can block URLs but there is a bug preventing that from working zaproxy/action-full-scan#83

@tdooner
Copy link
Contributor

tdooner commented Jul 25, 2024

@joeyg Hm, that sucks. Can we pass in a -configfile with these fields rather than having to pass in these escaped regexes on the command line?

@tdooner
Copy link
Contributor

tdooner commented Jul 26, 2024

@joeyg What is your capacity going to be to work on this? Do you want to keep taking this PR on or should we take it back?

@joeyg
Copy link
Contributor

joeyg commented Jul 26, 2024

@tdooner thanks for asking - you all should take it on if you need it done soon. My availability changes a lot from day to day.

@tdooner
Copy link
Contributor

tdooner commented Jul 29, 2024

Closing in favor of #116

@tdooner tdooner closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants