Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable three Rubocop cops #498

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Enable three Rubocop cops #498

wants to merge 2 commits into from

Conversation

tdooner
Copy link
Contributor

@tdooner tdooner commented Mar 11, 2025

Ticket

N/A - Noticed the lack of these rules while reviewing #496.

Changes

  • Enable three Rubocop cops
  • Run rubocop lint with new rules

Context for reviewers

Acceptance testing

  • No acceptance testing needed
    • This change will not affect the user experience (bugfix, dependency updates, etc.)
  • Acceptance testing prior to merge
    • This change can be verified visually via screenshots attached below or by sending a link to a local development environment to the acceptance tester
    • Acceptance testing should be done by design for visual changes, product for behavior/logic changes, or both for changes that impact both.
  • Acceptance testing after merge
    • This change is hard to test locally, so we'll test it in the demo environment (deployed automatically after merge.)
    • Make sure to notify the team once this PR is merged so we don't inadvertently deploy the unaccepted change to production. (e.g. :alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)

tdooner added 2 commits March 11, 2025 13:09
This commit enables:
* Layout/EmptyLineBetweenDefs - makes sure that two method definitions
  are separated by a blank line.
* Layout/ParameterAlignment - makes sure that method parameters are
  aligned with the first parameter
* Naming/VariableName - prohibits non-snake_case variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant