Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1488: Reset PDF margins back to 10 #321

Merged
merged 1 commit into from
Oct 16, 2024
Merged

1488: Reset PDF margins back to 10 #321

merged 1 commit into from
Oct 16, 2024

Conversation

allthesignals
Copy link
Contributor

Ticket

Addresses 1488

Changes

Sets back to the default. The previous size was too large.

This did fix a minor issue where defaults were apparently ignored in production.

Context for reviewers

It doesn't address any of the substance of 1488, unfortunately.

@tdooner
Copy link
Contributor

tdooner commented Oct 16, 2024

Merging despite test failures because the test failures are either addressed on a different branch (Bundle audit) or will be addressed separately (anchore-scan).

@tdooner tdooner changed the title 1488: Reset back to 10 1488: Reset PDF margins back to 10 Oct 16, 2024
@tdooner tdooner merged commit d9b431a into main Oct 16, 2024
10 of 12 checks passed
@tdooner tdooner deleted the wmg/try-page-number branch October 16, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants