Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surround most text in a "usa-prose" component #200

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

tdooner
Copy link
Contributor

@tdooner tdooner commented Aug 21, 2024

Ticket

N/A

Changes

The typography on our pages doesn't match the designs in general:
everything fees cramped with a short line-height and different
font-size. Upon further inspection of the USWDS page templates, most
body content is in a "Prose" component, which makes the text a bit more
readable.

This commit surrounds all the text in a "usa-prose" component.

It also updates the styling of the with the consent, since there
was an extra large bottom margin due to the

.

I didn't touch the payment details page, since Matt is concurrently
refactoring the whole thing.

Context for reviewers

I paired with Carmen and she thought this was a good idea.

Testing

I will record going through the flow for acceptance testing by Carmen.

The typography on our pages doesn't match the designs in general:
everything fees cramped with a short line-height and different
font-size. Upon further inspection of the USWDS page templates, most
body content is in a "Prose" component, which makes the text a bit more
readable.

This commit surrounds all the text in a "usa-prose" component.

It also updates the styling of the <label> with the consent, since there
was an extra large bottom margin due to the <p>.

I didn't touch the payment details page, since Matt is concurrently
refactoring the whole thing.
@tdooner
Copy link
Contributor Author

tdooner commented Aug 21, 2024

@carmenrosalop Here are before / after screenshots of every page in the flow. (Before is on the left.) Please advise if you see anything strange. The main weirdness to me is that the homepage text is kind of narrow, but to me it still looks ok and better than it was before.
Screenshot 2024-08-21 at 4 08 34 PM
Screenshot 2024-08-21 at 4 09 17 PM
Screenshot 2024-08-21 at 4 09 26 PM
Screenshot 2024-08-21 at 4 10 13 PM
Screenshot 2024-08-21 at 4 10 19 PM
Screenshot 2024-08-21 at 4 10 25 PM
Screenshot 2024-08-21 at 4 11 46 PM
Screenshot 2024-08-21 at 4 12 42 PM
Screenshot 2024-08-21 at 4 13 02 PM
Screenshot 2024-08-21 at 4 13 15 PM

@tdooner tdooner requested review from carmenrosalop and allthesignals and removed request for carmenrosalop August 21, 2024 23:16
@carmenrosalop carmenrosalop self-requested a review August 22, 2024 01:12
Copy link

@carmenrosalop carmenrosalop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG this looks SO MUCH BETTER! Thank you for taking the time to fix this non-urgent yet important improvement. Will be useful for readability 👀

Copy link

@carmenrosalop carmenrosalop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit, but wondering if we can make the "help text" length the same as the body text above
Screenshot 2024-08-21 at 6 25 08 PM

@tdooner tdooner merged commit 347c70f into main Aug 22, 2024
14 checks passed
@tdooner tdooner deleted the td/improve-typography branch August 22, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants