Implement remaining product metrics #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to create a dashboard of the unique number of caseworker users.
This will facilitate creating dashboards broken out per site.
tdooner
force-pushed
the
td/FFS-705-product-metrics
branch
from
b052fdf
to
e9c6024
Compare
This necessitates passing the `current_user` object into the CbvInvitationService, but necessary if we want to have a NewRelic understanding of the number of invitations per caseworker.
We need to track a few fields in order to give us metrics on how mayn accounts are linked, as well as the number of paystubs and account descriptions. This logic gets me worried for bugs, since it's in a critical place, so I'm putting it in a rescue block so it doesn't break the sending of the actual documents.
This commit adds metadata tracking for the seconds in two intervals: 1. invitation sent and flow start, and 2. flow start and flow completion Although, these can be reconstituted later from the database timestamps, it might be best to just send them to NewRelic so we can put them on a dashboard easily.
We will set NEW_RELIC_ENV=demo on our demo site, and NEW_RELIC_ENV=production on our production site.
tdooner
force-pushed
the
td/FFS-705-product-metrics
branch
from
e9c6024
to
05017d7
Compare
GeorgeCodes19
approved these changes
Aug 22, 2024
| let(:cbv_flow_invitation) { cbv_flow.cbv_flow_invitation } | ||
|
|
||
| before do | ||
| session[:cbv_flow_invitation] = cbv_flow_invitation | ||
| end | ||
|
|
||
| around do |ex| |
There was a problem hiding this comment.
what's going on here?
There was a problem hiding this comment.
I make an assertion in the test that it calculates the number of "seconds since flow started" correctly, so freezing time is necessary so the calculation is exact (and doesn't take into account the time it took for the test to run).
| @@ -1,4 +1,6 @@ | |||
| class Users::OmniauthCallbacksController < Devise::OmniauthCallbacksController | |||
| after_action :track_event | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves FFS-705.
Changes
site_idto all NewRelic eventsuser_idto ApplicantInvitedToFlow NewRelic eventsContext for reviewers
When we initially implemented NewRelic, it was too early and we didn't have all
the constructs necessary to instrument these product metrics. Now, we do, so
I've added metadata to various parts in order to capture all the metrics in the
attached ticket.
Testing
Now that the NewRelic account is set up, the easiest way to validate this change
is to merge this, build the dashboards, and then accept the ticket based off of
the dashboards as data flows in.