Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split JWTClaims filter for Exposed and ExposedNextDay #241

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

martinalig
Copy link
Contributor

This PR splits JWTClaims filter and introduces 2 different insert manager beans, one for the exposed request, and one for the exposed next day request.
Additionally, we simplify Exception Handling in controller and make InsertException abstract.

Closes #240

Copy link
Collaborator

@ineiti ineiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice - just some comments

Simplify Exception Handling in controller and make InsertException abstract.
@ineiti
Copy link
Collaborator

ineiti commented Sep 4, 2020

Nice - filtering at its best ;)

@martinalig martinalig merged commit e26dec7 into feature/insert-manager Sep 4, 2020
@martinalig martinalig deleted the feature/im-seperation branch September 4, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants