Code refactor for printing UI, API and client #2950
+15
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we list all available languages in the print form, getting the submittable languages is not necessary. https://github.com/DOMjudge/domjudge/blob/1400212da97354dfa7a7eb373a8583d781d38a5a/webapp/src/Form/Type/PrintType.php#L21 Signed-off-by: cubercsl <[email protected]>
Since the UI allows selecting any available language or plain text, the API should also keep consistent behavior. Signed-off-by: cubercsl <[email protected]>
It is not necessary to select entry_porint when printing. Signed-off-by: cubercsl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things.
But I think putting submitting and printing in one command is not a wise choice, which makes the code logic confusing.
Here is our implementation of a command line printing client that we used in a recent ICPC Regional for reference. If anyone thinks a separate print client implementation would be more appropriate, I can open another PR.
https://gist.github.com/cubercsl/809fcfdb65a7f88d6322cf0ab3505aa4