Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show medal and rank below each other on mobile scoreboard #2929

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Show medal and rank below each other on mobile scoreboard #2929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions webapp/templates/partials/scoreboard_table.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,15 +390,10 @@
{% endif %}
<tr class="{{ classes | join(' ') }}" data-team-id="{{ score.team.teamid }}" style="border-bottom-width: 0; height: 28px;">
{% if enable_ranking %}
<td class="scorepl {{medalColor}}" rowspan="2">
{# Only print rank when score is different from the previous team #}
{% if not displayRank %}
?
{% elseif previousTeam is null or scoreboard.scores[previousTeam.teamid].rank != score.rank %}
{{ score.rank }}
{% else %}
<td class="scorepl">
{% if medalsEnabled and medalColor != '' %}
<i class="fa fa-medal {{medalColor}} d-block me-2" style="font-size: 1.5rem;"></i>
{% endif %}
{% set previousTeam = score.team %}
</td>
{% endif %}
<td class="scoreaf">
Expand Down Expand Up @@ -486,6 +481,18 @@
{% endif %}
</tr>
<tr style="height: 32px;">
<td>
{# Only print rank when score is different from the previous team #}
<span class="d-block me-2">
{% if not displayRank %}
?
{% elseif previousTeam is null or scoreboard.scores[previousTeam.teamid].rank != score.rank %}
{{ score.rank }}
{% else %}
{% endif %}
</span>
{% set previousTeam = score.team %}
</td>
{% if showAffiliationLogos %}
{% set problemSpan = 3 %}
{% else %}
Expand Down
Loading