Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not clutter unit test output on CI with deprecation notices. #2927

Closed
wants to merge 1 commit into from

Conversation

meisterT
Copy link
Member

@meisterT meisterT commented Mar 1, 2025

If we actually care we should set up a separate test for it.

If we actually care we should set up a seperate test for it.
@meisterT meisterT marked this pull request as draft March 1, 2025 08:36
Copy link

github-actions bot commented Mar 1, 2025

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 6949655. ± Comparison against base commit f82c83e.

@vmcj
Copy link
Member

vmcj commented Mar 1, 2025

If we actually care we should set up a separate test for it.

We've done this for quite a while now and I rather not do an extra test for this as CI is already slow.
We use it here: https://github.com/DOMjudge/domjudge/pull/2927/files#diff-10407f9f203257ec9a7d9297775e7d7085e36ce06faeaf17450c25a1b6949a20L49 does that usecase still work?

@meisterT meisterT closed this Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants