Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hearts on scoreboard by using separate column #2921

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Improve hearts on scoreboard by using separate column #2921

merged 1 commit into from
Mar 2, 2025

Conversation

nickygerritsen
Copy link
Member

Before:
Screenshot 2025-02-28 at 18 07 46

After:
Screenshot 2025-02-28 at 18 07 37

Ignore the medal, that is fixed in #2919

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit b3f1417. ± Comparison against base commit 71b45e4.

♻️ This comment has been updated with latest results.

meisterT
meisterT approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@meisterT meisterT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I also tested locally that hearting the heart works still.

@nickygerritsen nickygerritsen force-pushed the improve-hearts branch 2 times, most recently from 3bb0492 to 500d276 Compare March 1, 2025 11:48
@nickygerritsen nickygerritsen added this pull request to the merge queue Mar 2, 2025
Merged via the queue into DOMjudge:main with commit 125fc90 Mar 2, 2025
37 checks passed
@nickygerritsen nickygerritsen deleted the improve-hearts branch March 2, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

@vmcj vmcj vmcj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickygerritsen @meisterT @vmcj