Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG test case visualisation for jury submission #2915

Merged
merged 4 commits into from
Mar 1, 2025
Merged

SVG test case visualisation for jury submission #2915

merged 4 commits into from
Mar 1, 2025

Conversation

Kevinjil
Copy link
Contributor

Fixes #2875

vmcj
vmcj reviewed Feb 28, 2025
View reviewed changes
@Kevinjil Kevinjil force-pushed the feature/svg-test-case-visualisation branch 3 times, most recently from 1029abe to 8208590 Compare February 28, 2025 17:34
@Kevinjil Kevinjil requested a review from vmcj February 28, 2025 18:08
@Kevinjil Kevinjil force-pushed the feature/svg-test-case-visualisation branch from 8208590 to 15fe3b1 Compare February 28, 2025 18:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 188a0b6. ± Comparison against base commit ede94dc.

♻️ This comment has been updated with latest results.

@Kevinjil Kevinjil force-pushed the feature/svg-test-case-visualisation branch 2 times, most recently from e1b9d90 to 9a21dab Compare February 28, 2025 21:23
@Kevinjil
Add a utility to sanitize SVG files
027965b 
The sanitizer library is the underlying library of several popular extensions for large CMS systems.
@Kevinjil Kevinjil force-pushed the feature/svg-test-case-visualisation branch from 9a21dab to 0c3f76d Compare March 1, 2025 00:21
meisterT
meisterT reviewed Mar 1, 2025
View reviewed changes
Copy link
Member

@meisterT meisterT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you upload a large SVG, how wide will that appear then?

@Kevinjil
Copy link
Contributor Author

Kevinjil commented Mar 1, 2025

If you upload a large SVG, how wide will that appear then?

Since the last commit, the configured max thumbnail size is enforced in CSS (200x200 PX by default)

@Kevinjil Kevinjil force-pushed the feature/svg-test-case-visualisation branch from 0c3f76d to 97365f5 Compare March 1, 2025 09:45
@Kevinjil Kevinjil force-pushed the feature/svg-test-case-visualisation branch from 97365f5 to 188a0b6 Compare March 1, 2025 10:11
@Kevinjil Kevinjil enabled auto-merge March 1, 2025 10:11
@Kevinjil Kevinjil added this pull request to the merge queue Mar 1, 2025
Merged via the queue into DOMjudge:main with commit b7d7b9a Mar 1, 2025
37 checks passed
@Kevinjil Kevinjil deleted the feature/svg-test-case-visualisation branch March 1, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

@vmcj vmcj vmcj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] Allow SVG as test case visualization
3 participants
@Kevinjil @meisterT @vmcj