Use Bash for all GitHub Actions CI jobs #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
ci_bash_posix
branch
2 times, most recently
from
ae77f50 to
98ad4c1
Compare
We didn't catch an error with an error being eaten away with a piped command. The benefits of being POSIX compliant are slim for the CI jobs. The -o pipefail is added for al scripts (also if they don't use a `|` yet) and where we don't have set -eu yet this is added but not the -x to keep the looks the same. Also fixes an unset ARCH option.
Kevinjil
approved these changes
Feb 28, 2025
nickygerritsen
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't catch an error with an error being eaten away with a piped command. The benefits of being POSIX compliant are slim for the CI jobs.
The -o pipefail is added for al scripts (also if they don't use a
|yet) and where we don't have set -eu yet this is added but not the -x to keep the looks the same.