Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the upload of the unit test results #2884

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/jobs/unit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ php $phpcov webapp/bin/phpunit -c webapp/phpunit.xml.dist webapp/tests/$unittest
UNITSUCCESS=$?

# Store the unit tests also in the root for the GHA
cp $ARTIFACTS/unit-tests.xml $DIR/
cp $ARTIFACTS/unit-tests.xml $DIR/unit-tests-${version}-${unittest}.xml

# Make sure the log exists before copy
touch ${DIR}/webapp/var/log/test.log
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
branches:
- main
- '[0-9]+.[0-9]+'
- fix_unit_test_upload_gha

jobs:
check-static-codecov:
Expand All @@ -18,6 +19,8 @@ jobs:
run: diff newcodecov .github/jobs/uploadcodecov.sh

unit-tests:
permissions:
checks: write
runs-on: ubuntu-24.04
timeout-minutes: 20
container:
Expand Down Expand Up @@ -79,3 +82,13 @@ jobs:
/opt/domjudge/domserver/webapp/var/log/*.log
/tmp/docker-logs
/tmp/artifacts

event_file:
name: "Post results assuming forks"
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
34 changes: 34 additions & 0 deletions .github/workflows/upload-unit-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Publish unit test results

on:
workflow_run:
workflows: ["Unit tests"]
types:
- completed
permissions: {}

jobs:
test-results:
name: Process test results
runs-on: ubuntu-latest
if: github.event.workflow_run.conclusion != 'skipped'
permissions:
# required by download step to access artifacts API
actions: read
# write the actual check-run
checks: write
# needed unless run with comment_mode: off
pull-requests: write
steps:
- name: Download and Extract Artifacts
uses: dawidd6/action-download-artifact@e7466d1a7587ed14867642c2ca74b5bcc1e19a2d
with:
run_id: ${{ github.event.workflow_run.id }}
path: artifacts
- name: Publish Test Results
uses: EnricoMi/publish-unit-test-result-action@v2
with:
commit: ${{ github.event.workflow_run.head_sha }}
event_file: artifacts/Event File/event.json
event_name: ${{ github.event.workflow_run.event }}
files: "tmp/artifacts/**/*.xml"
Loading