Allow shadowing from PC2 #2343
Allow shadowing from PC2 #2343
Conversation
vmcj
force-pushed
the
pc2_shadow
branch
4 times, most recently
from
ac907a1 to
8d9670a
Compare
| $freezeHour = floor($freezeStartSeconds / 3600); | ||
| $freezeMinutes = floor(($freezeStartSeconds % 3600) / 60); | ||
| $freezeSeconds = floor(($freezeStartSeconds % 60) / 60); | ||
| $freezeMilliseconds = $freezeStartSeconds - floor($freezeStartSeconds); |
There was a problem hiding this comment.
Please don't just reformat code if you're not touching it, and if you do, then do it in separate commits. Also, I disagree with this kind of removal of alignment spaces. It makes the code less readable.
There was a problem hiding this comment.
I think the reformatting was done in Nicky his PR.
I added a change to his commits but this branch is (currently) mostly to make the shadowing work for tonight.
There was a problem hiding this comment.
Yes, I found out afterwards, so let's have that discussion there.
As a temporary branch I think this is fine, but if this planned to be merged into main, then please rebase it on top of Nicky's merged branch, so that only the actual changes are shown in the PR.
There was a problem hiding this comment.
We opened nickygerritsen#1 for now so we can see the actual changes in this PR. I can't do that on the main repo since my branch is not in the main repo (yet)
nickygerritsen
force-pushed
the
pc2_shadow
branch
6 times, most recently
from
679de55 to
8861dd5
Compare
Co-authored-by: MCJ Vasseur <[email protected]>
Co-authored-by: MCJ Vasseur <[email protected]>
Also add comment to event classes that are unused.
Also fix some logic errors.
See: https://ccs-specs.icpc.io/2023-06/contest_api#contests and RELTIME: (-)?(h)*h:mm:ss(.uuu)?
Here we are not in line with the spec.
nickygerritsen
force-pushed
the
pc2_shadow
branch
from
8861dd5 to
6ae92b2
Compare
1 out of 3 systems we shadow from needs an extra syntax, given that we only run this code ourselves I think this is safe.