Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Symfony Form for jury clarifications. #2322

Merged

Conversation

nickygerritsen
Copy link
Member

Also sanitize only after converting to markdown. Fixes #2311

@nickygerritsen nickygerritsen force-pushed the jury-clarification-symfony-form branch from f590d36 to 1cf1720 Compare February 10, 2024 11:28
Also sanitize only after converting to markdown. Fixes DOMjudge#2311
@nickygerritsen nickygerritsen force-pushed the jury-clarification-symfony-form branch from 1cf1720 to 48a68a2 Compare February 10, 2024 12:31
Copy link
Member

@vmcj vmcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've little experience with those forms.

@meisterT
Copy link
Member

Code looks fine, feel free to merge. But I do have a couple more suggestions/nits (will write separate comments for each):

code blocks for teams do not look right in preview:
image

Once sent, it looks ok:
image

Interestingly enough the same works on the jury side:
image

@meisterT
Copy link
Member

The reply button after starting a reply is useless and collapses the reply-form. I think it should be replaced by the "send" button:
image

@meisterT
Copy link
Member

The reply form looks like a Matryoshka of boxes and clutter, remove at least these two:

image

Then "message" is unnecessary as there is only one text field and I don't see a use case to change the subject in a reply.

@nickygerritsen
Copy link
Member Author

Note that your comments are all about the team clarification page, which I didn't even touch. I do agree with the remakrs so we should fix them for sure.

@nickygerritsen nickygerritsen added this pull request to the merge queue Feb 17, 2024
Merged via the queue into DOMjudge:main with commit 2a947c1 Feb 17, 2024
21 checks passed
@nickygerritsen nickygerritsen deleted the jury-clarification-symfony-form branch February 17, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete markdown rendering in clarification requests
3 participants