Skip to content

Commit

Permalink
Allow GHA to upload and report the unit tests results
Browse files Browse the repository at this point in the history
See:
https://github.com/DOMjudge/domjudge/actions/runs/12247242151/job/34164708661?pr=2879

Here the push from dependabot failed to add the check-run results. Other
possible permissions:
https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#create-a-check-run

We expect the file to be named per matrix job but this was not updated
in the code so the upload action couldn't find the files.
  • Loading branch information
vmcj committed Feb 26, 2025
1 parent e982562 commit 54665f8
Show file tree
Hide file tree
Showing 3 changed files with 47 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/jobs/unit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ php $phpcov webapp/bin/phpunit -c webapp/phpunit.xml.dist webapp/tests/$unittest
UNITSUCCESS=$?

# Store the unit tests also in the root for the GHA
cp $ARTIFACTS/unit-tests.xml $DIR/
cp $ARTIFACTS/unit-tests.xml $DIR/unit-tests-${version}-${unittest}.xml

# Make sure the log exists before copy
touch ${DIR}/webapp/var/log/test.log
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
run: diff newcodecov .github/jobs/uploadcodecov.sh

unit-tests:
permissions:
checks: write
runs-on: ubuntu-24.04
timeout-minutes: 20
container:
Expand Down Expand Up @@ -87,3 +89,13 @@ jobs:
/opt/domjudge/domserver/webapp/var/log/*.log
/tmp/docker-logs
/tmp/artifacts
event_file:
name: "Post results assuming forks"
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
34 changes: 34 additions & 0 deletions .github/workflows/upload-unit-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Publish unit test results

on:
workflow_run:
workflows: ["Unit tests"]
types:
- completed
permissions: {}

jobs:
test-results:
name: Process test results
runs-on: ubuntu-latest
if: github.event.workflow_run.conclusion != 'skipped'
permissions:
# required by download step to access artifacts API
actions: read
# write the actual check-run
checks: write
# needed unless run with comment_mode: off
pull-requests: write
steps:
- name: Download and Extract Artifacts
uses: dawidd6/action-download-artifact@e7466d1a7587ed14867642c2ca74b5bcc1e19a2d
with:
run_id: ${{ github.event.workflow_run.id }}
path: artifacts
- name: Publish Test Results
uses: EnricoMi/publish-unit-test-result-action@v2
with:
commit: ${{ github.event.workflow_run.head_sha }}
event_file: artifacts/Event File/event.json
event_name: ${{ github.event.workflow_run.event }}
files: "tmp/artifacts/**/*.xml"

0 comments on commit 54665f8

Please sign in to comment.