Render contest validation errors more nicely. Fixes #2891

DOMjudge · Feb 28, 2025 · 2642394 · 2642394
1 parent 1b1261d
commit 2642394
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/webapp/src/Service/CheckConfigService.php b/webapp/src/Service/CheckConfigService.php
@@ -472,16 +472,23 @@ public function checkContestsValidate(): ConfigCheckItem
             foreach ($contest->getProblems() as $cp) {
                 if (empty($cp->getColor())) {
                     $result = ($result === 'E' ? 'E' : 'W');
-                    $cperrors[$cid] .= "No color for problem " . $cp->getShortname() . " in contest c" . $cid . "\n";
+                    $cperrors[$cid] .= "  - No color for problem " . $cp->getShortname() . " in contest c" . $cid . "\n";
                 }
             }
         }
 
         $desc = '';
         foreach ($contesterrors as $cid => $errors) {
-            $desc .= "Contest: c$cid: " .
-                /* @phpstan-ignore-next-line */
-                    (count($errors) == 0 ? 'no errors' : (string)$errors) ."\n" .$cperrors[$cid];
+            $desc .= "Contest: c$cid: ";
+            if (count($errors) == 0 && empty($cperrors[$cid])) {
+                $desc .= "no errors\n";
+            } else {
+                $desc .= "errors:\n";
+                foreach ($errors as $error) {
+                    $desc .= "  - " . $error->getPropertyPath() . ": " . $error->getMessage() . "\n";
+                }
+                $desc .= $cperrors[$cid];
+            }
         }
 
         $this->stopwatch->stop(__FUNCTION__);