Add test for desired precision in usgscsm_cam_test #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option --desired-precision to usgscsm_cam_test, and adds a CTX linescan dataset, originally named B17_016219_1978_XN_17N282W.json, which is a good real-world example on which to test distortion issues, such as #244. (The LRO NAC testcase in the repo does not have distortion problems.)
With this testcase, which I added with name tests/data/ctxLineScan.json (size on disk: 54K), this tool's output is as follows:
cd build; ./usgscsm_cam_test --model ../tests/data/ctxLineScan.json --sample-rate 100 --desired-precision 1e-8
Detected CSM plugin: UsgsAstroPluginCSM
Loaded a CSM model of type USGS_ASTRO_LINE_SCANNER_SENSOR_MODEL from ISD file ../tests/data/ctxLineScan.json.
... some stuff omitted ...
Desired precision: 1e-08
Max achieved precision: 0.00313679
So it shows that one can't reach desired precision as mentioned in that issue.