updated distortion to closer match ISIS #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessemapel
reviewed
Oct 25, 2019
| @@ -30,5 +30,5 @@ void removeDistortion(double dx, double dy, double &ux, double &uy, | |||
| void applyDistortion(double ux, double uy, double &dx, double &dy, | |||
| const std::vector<double> opticalDistCoeffs, | |||
| DistortionType distortionType, | |||
| const double desiredPrecision = 0, const double tolerance = 1.0E-6); | |||
| const double desiredPrecision = 1.0E-6, const double tolerance = 1.0E-6); | |||
There was a problem hiding this comment.
I would make this one argument, the tolerance. The desired precision should be handled by the model that calls this and converted into a convergence tolerance.
|
Like Stuart, I also agree with what Jesse said. |
|
For now this is basically a bug fix, we should probably talk more about how to properly solve this problem here: #244 |
jessemapel
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased max iteration count, loosened precision, and acceptance criteria for Radial Distortion.
Isis uses pixel pitch as the tolerance, CSM doesn't have access to pixel pitch so just punting it for now.