Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow addl plot args #163

Merged
merged 4 commits into from
Jan 25, 2017
Merged

Conversation

lindsayplatt
Copy link

Now plotEGRET("fluxBiasMulti", lamprey_nitrate, estdat, preds, meta, moreTitle="LINEAR") won't produce an error about multiple actual arguments. See #107

Copy link
Contributor

@wdwatkins wdwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aappling-usgs
Copy link
Collaborator

Looks good! While we're doing this, I wanted to revive a request I made in #138 : "can we take out the flow normalized concentrations with plotFlowNorm=FALSE?" - this would be very similar to what you just did for moreTitle=NULL, and I think it makes sense for the same reason moreTitle does.

Would also like to suggest that the default for moreTitle be 'loadflex' rather than NULL. It's not very descriptive, but it will look better out of the box than NULL.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.15% when pulling ebb8f6a on lindsaycarr:allow-addl-plot-args into 346c2ee on USGS-R:master.

@aappling-usgs
Copy link
Collaborator

Thanks! 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.15% when pulling 26d3a42 on lindsaycarr:allow-addl-plot-args into 346c2ee on USGS-R:master.

@wdwatkins wdwatkins merged commit 0a3bce1 into DOI-USGS:master Jan 25, 2017
@lindsayplatt lindsayplatt deleted the allow-addl-plot-args branch January 25, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants