Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stateCd "whatNWISsites" function fix #729

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

stateCd "whatNWISsites" function fix #729

wants to merge 2 commits into from

Conversation

ldecicco-USGS
Copy link
Collaborator

Two things here:

  1. When we changed the stateCd stuff for readNWISdata, it also changed it for whatNWISsites. Since in whatNWISsites we're still hitting the "waterservices" endpoint (not "waterdata"), we don't want that to happen.
  2. A user wanted to do:
whatNWISsites(stateCd = "NY", service="gwlevels")

That's cool...but it wasn't something we were doing. I added a line that took the service argument and converted it to the appropriate "hasDataTypeCd" argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ldecicco-USGS