Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to isd_generate.py to allow for a NAIF radius override #486

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Aug 18, 2022

  1. Update to isd_generate.py to allow for a NAIF radius override

    Based on this RFC, we want to change our Mars pipeline to use a sphere. https://astrodiscuss.usgs.gov/t/appl-rfc-use-iau-sphere-for-hirise-dtm-projects-in-socet-set/428
    
    Currently ALE uses the Mars elliptical defaults from the NAIF kernels. This update allows the user to override the kernels and set a spherical radius for both semimajor and semiminor in the ISD.
    
    This is not only needed for Mars. For triaxial bodies, the IAU recommends a best-fit sphere should also be set for map products. References (DOI) are listed in the updated help for the current IAU values.
    thareUSGS committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    163d87d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    331778f View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2022

  1. update to allow ellipse, minor help update

    Add --semimajor and --semiminor parameters. I tried nargs="+" for --radius but fought for too long with argparse to do all the checking (like checking it is float). I am fine with these options but happy to hear better ways to use argparse.
    thareUSGS committed Aug 20, 2022
    Configuration menu
    Copy the full SHA
    f29fe97 View commit details
    Browse the repository at this point in the history