Merging 1.0 changes into main #22
Conversation
|
2 tests failing, coming back to this tonight. |
recipe/meta.yaml
Outdated
There was a problem hiding this comment.
Do we want to reflect the staged-recipes/spiceql recipe changes here as well?
There was a problem hiding this comment.
We really should after that PR is merged.
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| python-version: ["3.8", "3.9", "3.10", "3.11"] |
There was a problem hiding this comment.
Just want to confirm that we are not testing against python3.8
There was a problem hiding this comment.
I should put that back in, that was part of me testing out why python was failing in a weird way.
There was a problem hiding this comment.
ugh, it fails on 3.8 because of a linking issue on import with PyCMethod_New, probably a swig compatibility issue? I think in the spirit of just getting this merged so I can move on to other things Im going to disable and make an issue of it.
No description provided.