Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFN bootstrap results #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ldecicco-USGS
Copy link
Collaborator

This fork of EGRETci has modified runPairsBoot to output the GFN bootstrap results. In addition to xConc and xFlux, the new version also outputs xConcQTC, xFluxQTC, xConcCQTC, xConcCQTC, which can be used to calculate GFN confidence intervals.

I've kept the fork as simple as possible to minimize bugs. However, if you require additional output for your project, create an issue and I'll work with you to solve it.

This is an unofficial fork and is unsupported by the EGRETci development team. User beware!

library(EGRET) install.packages('path_to_forked_package/EGRETci', repos=NULL, type="source") #install fork library(EGRETci)

eList <- Choptank_eList year1 <- 1985 year2 <- 2009

pairOut_2 <- runPairs(eList, year1, year2, windowSide = 7) boot_pair_out <- runPairsBoot(eList, pairOut_2) boot_pair_out$xFluxQTC

@ldecicco-USGS
Copy link
Collaborator Author

I'll get Bob to take a look at the proposed changes. Ideally...we could revert the changes to the README and the vignettes (so that doesn't get propagated up to the main repository).

If you want to get really fancy with your contribution, you could add a test in the "tests_boot_tests.R" file. An ideal test would make sure that the changes you added are what you expect them to be...and what you don't want changed if someone in the future starts messing with the code.

@coveralls
Copy link

coveralls commented May 1, 2019

Coverage Status

Coverage increased (+1.0%) to 68.036% when pulling 21adfc3 on thodson-usgs:master into fa3fa79 on USGS-R:master.

@thodson-usgs
Copy link

Sure, I'll revert the README and update the doc box.
I was confused by your vignette comment. Did you want to add a new vignette, or leave the vignettes as they were?

@ldecicco-USGS
Copy link
Collaborator Author

In this pull request, you are deleting the files in the inst/doc folder. This is happening because devtools has changed it's behavior (and now deletes it). If you can figure out how to revert the delete, that would be great. If not, don't worry about it...I've been debating taking those off the repo anyway.

@thodson-usgs thodson-usgs force-pushed the master branch 6 times, most recently from 0ae9d25 to aa69d8d Compare May 2, 2019 20:02
@thodson-usgs
Copy link

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants