Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Running Locally and Add Test Matrix #8

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

iguessthislldo
Copy link
Member

@iguessthislldo iguessthislldo commented Jan 18, 2025

@jwillemsen
Copy link
Member

When nothing breaks feel free to merge. In the past we did run the test matrix on the ATCD scoreboard but it was disabled at some point because we ran out of disk space at Vanderbilt.

@iguessthislldo
Copy link
Member Author

I would guess that would be caused by the database part. I removed that in DOCGroup/autobuild#74.

@iguessthislldo
Copy link
Member Author

So I'm pretty confident that this should work since it works for me locally. The only thing I could see breaking is if there's something weird about the system like it's pretty old.

@iguessthislldo iguessthislldo merged commit baaa238 into DOCGroup:master Jan 21, 2025
@iguessthislldo iguessthislldo deleted the igtd/test-matrix branch January 21, 2025 18:45
@jwillemsen
Copy link
Member

Integrated page is now empty and the new links to the matrix pages give an error

@iguessthislldo
Copy link
Member Author

iguessthislldo commented Jan 21, 2025

What is the output the naboo_dre.sh script?

@iguessthislldo
Copy link
Member Author

So I ran it locally again and I don't have the same results, but the issue I saw was that some of our builds weren't available anymore. At the very least I have to change the test matrix to handle builds being missing. I still would like to see the output of that script though.

@iguessthislldo
Copy link
Member Author

Okay, another thought I had is the way naboo_dre.sh is written it does a git pull on its own repo, but that doesn't update naboo_dre.sh because it's already running. If you ran it without updating the script, it would run the old script and that would explain why the test matrices are missing.

I think I also see why the integrated page broke. I added a new elements to the scoreboard build XML and for some reason the integrated page generator uses a very similar, but completely separate XML parser for the very same file. I'm still not sure why I didn't see error this before I merged the PR though.

iguessthislldo added a commit to iguessthislldo/doc-scoreboard that referenced this pull request Jan 21, 2025
See DOCGroup#8.

These changes try to make the script more robust by not exiting on error
immediately and rerunning itself after an update.
iguessthislldo added a commit to iguessthislldo/autobuild that referenced this pull request Jan 21, 2025
See DOCGroup/scoreboard#8

These changes fix the parsing in the integrated page generator and try
to make matrix.py more robust by inserting skipped tests when builds or
test results cause an error instead of crashing.
@iguessthislldo
Copy link
Member Author

I've created #9 and DOCGroup/autobuild#77. The script changes in this repo are not strictly necessary, but I thought it was a good idea to make the script a little more robust. You'll should to do a manual pull on this repo before running it again.

@iguessthislldo
Copy link
Member Author

Output of the scripts on master on naboo
naboo_202501220848.txt

Yeah, that's the same error I saw, so the autobuild PR should fix that. From the current scoreboard, it looks like you already ran with the fixed version.

@jwillemsen
Copy link
Member

Yes, I ran it when I noticed your merge, it now all seems to work again, thanks for the improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants