Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stats for unexpected message ID occurences #220

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add stats for unexpected message ID occurences #220

wants to merge 1 commit into from

Conversation

pspacek
Copy link
Contributor

@pspacek pspacek commented Jan 31, 2023 •
edited
Loading

Fixes: #222

pspacek
pspacek commented Jan 31, 2023
View reviewed changes
src/dnsperf.c
if (stats->num_unexpected > 0)
printf(" Unexpected IDs: %" PRIu64 " (%.2lf%%)\n",
stats->num_unexpected,
PERF_SAFE_DIV(100.0 * stats->num_unexpected, stats->num_sent));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's questionable if % from num_sent if good choice, or if it could be percentage from num_timedout...

@pspacek
Copy link
Contributor Author

pspacek commented Jan 31, 2023

Example:

$ src/dnsperf -Q 5 -d /tmp/qlist -s 192.168.0.1 -l 10 -O latency-histogram -O suppress=unexpected,timeout -l5 -t0.1

Statistics:

  Queries sent:         25
  Queries completed:    24 (96.00%)
  Queries lost:         1 (4.00%)
  Unexpected IDs:       1 (4.00%)

  Response codes:       NOERROR 24 (100.00%)
  Average packet size:  request 17, response 228
  Run time (s):         5.000190
  Queries per second:   4.799818

  Average Latency (s):  0.020240 (min 0.014806, max 0.029595)
  Latency StdDev (s):   0.004594
  Latency bucket (s):   answer count
  0.014592 - 0.014847:  1
  0.014848 - 0.015103:  1
  0.015872 - 0.016127:  1
  0.016128 - 0.016383:  2
  0.016384 - 0.016895:  1
  0.016896 - 0.017407:  3
  0.017408 - 0.017919:  2
  0.018432 - 0.018943:  1
  0.018944 - 0.019455:  1
  0.019968 - 0.020479:  4
  0.023552 - 0.024063:  2
  0.024576 - 0.025087:  1
  0.027136 - 0.027647:  1
  0.027648 - 0.028159:  1
  0.028672 - 0.029183:  1
  0.029184 - 0.029695:  1

@pspacek pspacek mentioned this pull request Feb 1, 2023
Closed
@pspacek pspacek force-pushed the count-unexpected branch 3 times, most recently from 8e2ee06 to c55aad0 Compare February 1, 2023 12:41
@pspacek pspacek changed the title Summarize unexpected message IDs Fix unexpected message ID supression and add stats for it Feb 1, 2023
@jelu
Copy link
Member

jelu commented Feb 1, 2023

Please don't mix fixes with new features

@pspacek
Add stats for unexpected message IDs
2480a73 
- `dnsperf`:
  - Count and report unexpected message IDs in statistics
    as indication that configured timeout might be too short
@pspacek pspacek changed the title Fix unexpected message ID supression and add stats for it Add stats for unexpected message ID occurences Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nonsense response latency - equal to unix timestamp
2 participants
@pspacek @jelu