Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Policies are allowed to return no description #108

Merged
merged 8 commits into from
Mar 17, 2025

Conversation

DNKpp
Copy link
Owner

@DNKpp DNKpp commented Mar 17, 2025

No description provided.

@DNKpp DNKpp added the enhancement New feature or request label Mar 17, 2025
@coveralls
Copy link

coveralls commented Mar 17, 2025

Pull Request Test Coverage Report for Build 13905936237

Details

  • 20 of 20 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.703%

Totals Coverage Status
Change from base Build 13902709685: 0.001%
Covered Lines: 1678
Relevant Lines: 1683

💛 - Coveralls

Copy link

codacy-production bot commented Mar 17, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for bd92dc41 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bd92dc4) Report Missing Report Missing Report Missing
Head commit (e0a6296) 1689 1681 99.53%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#108) 20 20 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.62%. Comparing base (84d23ca) to head (e0a6296).
Report is 32 commits behind head on development.

Files with missing lines Patch % Lines
include/mimic++/Expectation.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #108      +/-   ##
===============================================
+ Coverage        96.49%   96.62%   +0.13%     
===============================================
  Files               46       46              
  Lines             1683     1689       +6     
  Branches           631      633       +2     
===============================================
+ Hits              1624     1632       +8     
+ Misses              12       10       -2     
  Partials            47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DNKpp DNKpp force-pushed the dev/ExpectationPolicy_NullDescription branch from f93bb2c to e0a6296 Compare March 17, 2025 20:36
@DNKpp DNKpp merged commit e0a6296 into development Mar 17, 2025
36 of 37 checks passed
@DNKpp DNKpp deleted the dev/ExpectationPolicy_NullDescription branch March 17, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants