Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bugs in the Conditional Questions functionality: #3461

Conversation

johnpinto1
Copy link
Contributor

 - In case of conditional question with checkbox answers the removed
   questions were not being removed from view, nor was the answer to
these questions (which persisted in the db.

Changes:
- Fixed the broken functionality in the method remove_answers_list in app/helpers/conditions_helper.rb.
- Removed and destroyed the answers of the removed questions.
- Updated RSpec tests for Conditional Questions functionality.

Reason for this fix:

An university have reported that conditional questions don't work as expected in template for one of their templates.

What happens:

Conditions for question 18 don't work.
In the past, conditions for questions Conditions for questions 8a failed too. On the day we met with them, conditions for 8a worked.

What should happen:

User says: 'When Q.18 is answered ‘None of the above applies’, Q19, 20 & 21 should go, but they are still there'. Note that the behaviour of the questions is very random. On the day met with them questions 20 and 21 had gone, only 19 was still present.

Note: the architecture of conditions within the template is that some conditions include questions that also have conditions attached to them (conditional questions within conditional questions).

We asked them to send us a list of all the conditions within their template so that we can examine the behaviour. Document attached.

     - In case of conditional question with checkbox answers the removed
       questions were not being removed from view, nor was the answer to
    these questions (which persisted in the db.

    Changes:
    - Fixed the broken functionality in the method remove_answers_list in
      app/helpers/conditions_helper.rb.
    - Removed and destroyed the answers of the removed questions.
    - Updated RSpec tests for Conditional Questions functionality.
Copy link

</tr>
1 Error
🚫

Please include a CHANGELOG entry.

You can find it at [CHANGELOG.md](https://github.com/DMPRoadmap/roadmap/blob/main/CHANGELOG.md).
1 Warning
⚠️ This PR is too big! Consider breaking it down into smaller PRs.

Generated by 🚫 Danger

@johnpinto1
Copy link
Contributor Author

@aaronskiba & @benjaminfaure My bad. I did not check my code changes with Rubocop. Will fix.

@johnpinto1
Copy link
Contributor Author

Will fix issues and create a new PR.

@johnpinto1 johnpinto1 closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant