Cast learning_rate to float lambda for pickle safety when doing model.load #1901
+43
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssed a function with non-float types
araffin
reviewed
Apr 19, 2024
stable_baselines3/common/utils.py
Outdated
| @@ -92,7 +92,7 @@ def get_schedule_fn(value_schedule: Union[Schedule, float]) -> Schedule: | |||
| value_schedule = constant_fn(float(value_schedule)) | |||
| else: | |||
| assert callable(value_schedule) | |||
| return value_schedule | |||
| return lambda _: float(value_schedule(_)) | |||
There was a problem hiding this comment.
maybe a better solution is to do a call to value_schedule(1.0) and check that the return type is a float (and output a useful error message if not).
There was a problem hiding this comment.
or, what you do is fine but I would explicitly name the parameter progress_remaining and add a comment of why
There was a problem hiding this comment.
Hm... I see the value in both. Let me noodle a bit and I'll see if I can sort it out during my lunch. Thanks araffin!
|
Awesome! Thanks again araffin! The docs on SB3 you and the crew wrote and your guidance made this a breeze :) |
friedeggs
pushed a commit
to friedeggs/stable-baselines3
that referenced
this pull request
Jul 22, 2024
….load (DLR-RM#1901) * create failing test for unpickle error * Fix learning_rate argument causing failure in weights_only=True if passed a function with non-float types * Updated with feedback from araffin on PR#1901 * Update test and version * Update changelog and SBX doc --------- Co-authored-by: Antonin Raffin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1900
Motivation and Context
closes [Bug]: if learning_rate function uses special types, they can cause torch.load to fail when weights_only=True #1900
Types of changes
Checklist
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)Note: You can run most of the checks using
make commit-checks.Note: we are using a maximum length of 127 characters per line