T8 io reader #370
Draft
T8 io reader #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
November 21, 2022 16:59
Currently they are not filled with anything meaningfull.
Basically move routines from t8_cmesh_readmshfile.cxx to t8_gmsh_reader.cxx The logic changes very little
Check if one can open the file, if a supported msh-version is used and if it is compatible with the geometry backend used.
There is a bug - remove it.
In the future, the routines in cmesh_readmshfile.cxx should not be used directly, only via the IO interface.
added 2 commits
November 24, 2022 15:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first implementation of an T8_IO_reader.
All readmsh-file routines are moved into the
t8_gmsh_readerfolder. As soon as we decide that the IO-interface is fully functional no other file should use these routines directly, but via the IO-interface.This implementation demonstrates how to implement a T8_IO_reader. In a first step, via
set_sourcethe source is opend and readability is checked. In the second step we read the source and construct a cmesh from its data.The
t8_IO_readfunction controlls the reading-routine for all processes, such that only a single process should read and ifT8_PARTITIONis set it partitions the cmesh over all available processes.Merge #368 before converting this into a PR.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
The author added a BSD statement to
doc/(or already has one)The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
All tests pass (in various configurations, this should be executed automatically in a github action)
New source/header files are properly added to the Makefiles
The reviewer executed the new code features at least once and checked the results manually
The code is covered in an existing or new test case
New tests use the Google Test framework
The code follows the t8code coding guidelines
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Testing of this template: If you feel something is missing from this list, contact the developers